Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: build and push evm contract docs to github pages #211

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

ci: build and push evm contract docs to github pages #211

wants to merge 14 commits into from

Conversation

TanvirDeol
Copy link

@TanvirDeol TanvirDeol commented Jan 31, 2025 •
edited by jira bot
Loading

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (432449d) to head (6ae1463).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files          48       48           
  Lines         754      754           
  Branches      154      154           
=======================================
  Hits          742      742           
  Misses          3        3           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TanvirDeol TanvirDeol marked this pull request as ready for review February 1, 2025 00:08
@TanvirDeol TanvirDeol requested a review from a team as a code owner February 1, 2025 00:08
milapsheth
milapsheth reviewed Feb 6, 2025
View reviewed changes
.github/actions/upload-docs/action.yaml Show resolved Hide resolved
.github/actions/upload-docs/action.yaml
branches:
description: "Branches to trigger the workflow on"
required: false
default: "main,ci/evm-docs-to-github-pages"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove PR branch

.github/actions/upload-docs/action.yaml Outdated Show resolved Hide resolved
.github/actions/upload-docs/action.yaml Outdated Show resolved Hide resolved
scripts/generateOverviewDocs.js Outdated Show resolved Hide resolved
scripts/generateOverviewDocs.js Outdated Show resolved Hide resolved
scripts/generateOverviewDocs.js Show resolved Hide resolved
scripts/generateOverviewDocs.js Outdated Show resolved Hide resolved
.github/workflows/upload-docs.yaml
runs-on: blacksmith-2vcpu-ubuntu-2204
steps:
- name: Run Upload Docs Action
uses: axelarnetwork/axelar-gmp-sdk-solidity/.github/actions/upload-docs@ci/evm-docs-to-github-pages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: change branch

scripts/generateOverviewDocs.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to duplicate this script everywhere, think about reusing it everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanvirDeol @milapsheth