Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove ValidateBasic in cli #2076

Merged
merged 2 commits into from
Jan 3, 2024
Merged

refactor: remove ValidateBasic in cli #2076

merged 2 commits into from
Jan 3, 2024

Conversation

lukema95
Copy link
Contributor

Description

The ValidateBasic function has been called in the GenerateOrBroadcastTxWithFactory function, so we no longer need to add the ValidateBasic function when writing Cli. Related PRs can be viewed at: cosmos/cosmos-sdk#9236 (comment)

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@lukema95 lukema95 requested a review from a team as a code owner December 31, 2023 05:40
fish-sammy
fish-sammy approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@fish-sammy fish-sammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@cgorenflo cgorenflo merged commit 899e7f7 into axelarnetwork:main Jan 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fish-sammy fish-sammy fish-sammy approved these changes

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukema95 @fish-sammy @cgorenflo