-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(releases): add Stellar GMP and ITS release #523
base: main
Are you sure you want to change the base?
Conversation
node evm/interchainTokenFactory.js --action deployInterchainToken -n [source-chain] --destinationChain stellar --salt "salt" --name "test" --symbol "test" --decimals 18 | ||
|
||
node evm/interchainTokenFactory.js --action deployRemoteInterchainToken -n [source-chain] --destinationChain stellar --salt "salt" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node stellar/its.js execute
is missing, created a ticket: https://axelarnetwork.atlassian.net/browse/AXE-7374
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP: #532
|
||
```bash | ||
node stellar/its.js add-trusted-chains axelar | ||
node stellar/its.js add-trusted-chains all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node stellar/its.js add-trusted-chains all
is missing, created a ticket: https://axelarnetwork.atlassian.net/browse/AXE-7373
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you numbered the steps in the instruction, it would be easier to follow and more importantly, successful deployment depends on the correct sequences of events to occur.
|
||
- [ ] Stellar → EVM GMP call | ||
|
||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standard amplifier GMP cmds don't need to be included here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caps is only needed for abbreviations, call the file 2025-01-Stellar-GMP-v1.0.0.md
?
|
||
## Background | ||
|
||
1. This is Cosmwasm Deployment for Stellar GMP v1.0.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checklist is weird. Link to the release as in other docs. Also, the latest axelar-amplifier official release should be used here, not the stellar release version
|
||
### Stellar to EVM | ||
|
||
- [ ] Deploy Native Interchain Token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can switch to numbering here, since we aren't really ticking off the boxes
STELLAR_TOKEN_ADDRESS=CDLZFC3SYJYDZT7K67VZ75HPJVIEUVNIXF47ZG2FB2RMQQVU2HHGCYSC # Testnet | ||
#STELLAR_TOKEN_ADDRESS=CAS3J7GYLGXMF6TDJBBYYSE3HQ6BBSMLNUQ34T6TZMYMW2EVH34XOWMA # Mainnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this mentioned? this should be part of the stellar config
CHAIN=stellar | ||
``` | ||
|
||
Deploy Stellar Gateway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before deployment can be started, an initial stellar chain config needs to be added in the config. Showcase that
```bash | ||
[7] node evm/its.js -n all --action setTrustedAddress --trustedChain stellar --trustedAddress hub | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still missing the registration step for Stellar on ITS hub contract. See Sui ITS release doc
|
||
node stellar/its.js deploy-remote-canonical-token $STELLAR_TOKEN_ADDRESS avalanche $STELLAR_TOKEN_ADDRESS 1 | ||
|
||
node evm/gateway.js -n avalanche --action execute --payload $PAYLOAD --sourceChain axelar --sourceAddress $ITS_HUB_ADDRESS --messageId 0xd8adcfdd262da322ac5350704ee50afb0a944e5bb08c9e887f11a7528e157de9-461 --destination 0x549Ec0Df306248e2AbDa6e71a0C0aDf3c9FB7886 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid hardcoding addresses, create a $WALLET
to reuse deployer address if needed
- [ ] Deploy Native Interchain Token | ||
|
||
```bash | ||
node stellar/its.js deploy-interchain-token test test 18 0x1234 10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
symbol should be TEST
to avoid confusion
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
Co-authored-by: Milap Sheth <[email protected]>
AXE-7293