Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add expected invoke auth error for unit tests #52

Merged
merged 11 commits into from
Nov 4, 2024
Merged

test: add expected invoke auth error for unit tests #52

merged 11 commits into from
Nov 4, 2024

Conversation

ahramy
Copy link
Contributor

@ahramy ahramy commented Oct 31, 2024 •
edited by jira bot
Loading

@ahramy ahramy requested a review from a team as a code owner October 31, 2024 05:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (12cba3b) to head (413edfe).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   99.43%   99.45%   +0.02%     
==========================================
  Files          28       28              
  Lines        2990     2949      -41     
==========================================
- Hits         2973     2933      -40     
+ Misses         17       16       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hydrobeam
hydrobeam reviewed Oct 31, 2024
View reviewed changes
contracts/axelar-gateway/src/test_gateway.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/test_gateway.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/test_gateway.rs Outdated Show resolved Hide resolved
contracts/axelar-gateway/src/testutils.rs Outdated Show resolved Hide resolved
@milapsheth
Copy link
Member

PR scope should be something like test: ...

@ahramy ahramy changed the title feat: add expected auth error for unit tests test: add expected auth error for unit tests Nov 3, 2024
@ahramy ahramy changed the title test: add expected auth error for unit tests test: add expected invalid action error for unit tests Nov 3, 2024
@ahramy ahramy changed the title test: add expected invalid action error for unit tests test: add expected invoke auth error for unit tests Nov 3, 2024
@ahramy ahramy merged commit 890bfcf into main Nov 4, 2024
5 checks passed
@ahramy ahramy deleted the feat/add-expected-auth-error-to-test branch November 4, 2024 06:22
@talalashraf talalashraf mentioned this pull request Jan 17, 2025
Merged
@ahramy ahramy mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

@hydrobeam hydrobeam hydrobeam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahramy @codecov-commenter @milapsheth @hydrobeam