Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package descriptions #226

Merged
merged 12 commits into from
Jan 29, 2025
Merged

chore: update package descriptions #226

merged 12 commits into from
Jan 29, 2025

Conversation

ahramy
Copy link
Contributor

@ahramy ahramy commented Jan 28, 2025

@ahramy ahramy requested a review from a team as a code owner January 28, 2025 19:48
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (0ea493f) to head (028317f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          68       68           
  Lines        3653     3653           
=======================================
  Hits         3539     3539           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nbayindirli nbayindirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like in the contract deployments PR, we should use the actual contract names, e.g. AxelarGasService instead of Axelar Gas Service. This usually ends up being useful for debugging and refactors, even in documentation

So <real contract name> Stellar contract, responsible for ...

contracts/stellar-axelar-gas-service/Cargo.toml Outdated Show resolved Hide resolved
contracts/stellar-axelar-gateway/Cargo.toml Outdated Show resolved Hide resolved
contracts/stellar-axelar-operators/Cargo.toml Outdated Show resolved Hide resolved
contracts/stellar-example/Cargo.toml Outdated Show resolved Hide resolved
contracts/stellar-interchain-token-service/Cargo.toml Outdated Show resolved Hide resolved
contracts/stellar-interchain-token/Cargo.toml Outdated Show resolved Hide resolved
contracts/stellar-token-manager/Cargo.toml Outdated Show resolved Hide resolved
contracts/stellar-upgrader/Cargo.toml Outdated Show resolved Hide resolved
@ahramy ahramy changed the title chore: update descriptions chore: update package descriptions Jan 29, 2025
@ahramy ahramy merged commit 1881ec7 into main Jan 29, 2025
7 checks passed
@ahramy ahramy deleted the chore/update-descriptions branch January 29, 2025 06:00
@talalashraf talalashraf mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants