feat(interchain-token-service): register canonical interchain token #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement register canonical token - add helper for chain_name_hash
AttissNgo
changed the title
- remove unnecessary clone in canonical_token test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 93.88% 93.98% +0.10%
==========================================
Files 51 51
Lines 2895 2945 +50
==========================================
+ Hits 2718 2768 +50
Misses 177 177 ☔ View full report in Codecov by Sentry. |
|
PR scope should be |
milapsheth
reviewed
Dec 14, 2024
AttissNgo
changed the title
- make cannonical_token_deploy_salt internal function
milapsheth
approved these changes
Dec 14, 2024
- add docstring to register_canonical_token - add golden test for token id derivation
- remove unnecessary clone in test
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-6745