refactor(interchain-token-service): change trusted address to trusted chain #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- store trusted chains rather than trusted addresses - ITS Hub address added to constructor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 94.07% 94.13% +0.05%
==========================================
Files 48 48
Lines 2752 2744 -8
==========================================
- Hits 2589 2583 -6
+ Misses 163 161 -2 ☔ View full report in Codecov by Sentry. |
milapsheth
changed the title
- fix test assert statements in trusted_address.rs
milapsheth
reviewed
Dec 10, 2024
- change trusted_address to is_trusted_address - minor fixes
- merge branch 'main' into refactor/its-trusted-chain
milapsheth
approved these changes
Dec 11, 2024
- move code from get_call_params into pay_gas_and_call_contract - use assert_invoke_auth_ok! in trusted_chain tests instead of mocking env auth
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-6872