Remove dependency on zinfo C library #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdpsin
reviewed
Oct 20, 2022
|
Does this change mean it is now possible to use the |
rdpsin
requested changes
Oct 20, 2022
vkuzniet
force-pushed
the
remove-clibrary
branch
from
3de006d to
346951d
Compare
rdpsin
requested changes
Oct 21, 2022
wmesard
suggested changes
Oct 21, 2022
Signed-off-by: Viktor Kuznietsov <[email protected]>
vkuzniet
force-pushed
the
remove-clibrary
branch
from
346951d to
82f4326
Compare
rdpsin
requested changes
Nov 3, 2022
rdpsin
approved these changes
Nov 3, 2022
Yes, since |
wmesard
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Viktor Kuznietsov [email protected]
Issue #, if available:
#78
Description of changes:
Removed linking to zinfo.a. Also moved the C files to soci.
gzip_zinfo.go also gets the unmarshaling of gzip_zinfo C struct, which is used in ztoc tests.
Testing performed:
make test && make check && make integrationpassBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.