Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] model_dialect -> framework_dialect #51

Merged
merged 2 commits into from
Feb 11, 2023
Merged

[Refactor] model_dialect -> framework_dialect #51

merged 2 commits into from
Feb 11, 2023

Conversation

comaniac
Copy link
Contributor

Description

The original name, "model dialect", is inaccurate, since these dialects are framework specific instead of model.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

cc @chhzh123

@comaniac comaniac mentioned this pull request Feb 10, 2023
Closed
4 tasks
chhzh123
chhzh123 approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@chhzh123 chhzh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit d2bcf59 into awslabs:main Feb 11, 2023
@comaniac
Copy link
Contributor Author

Thanks @chhzh123

@comaniac comaniac deleted the framework_dialect branch February 11, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhzh123 chhzh123 chhzh123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@comaniac @chhzh123