Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transformers import order in megatron scripts #5

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix transformers import order in megatron scripts #5

merged 1 commit into from
Jan 19, 2023

Conversation

szhengac
Copy link
Contributor

Description

import transformers needs to be placed before import megatron, otherwise we will receive segfault for more recent transformers.

Checklist

  • PR's title starts with a category (e.g. [Bugfix], [Model], [Tutorial], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

comaniac
comaniac approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chhzh123 chhzh123 merged commit f868eb8 into awslabs:main Jan 19, 2023
chhzh123 pushed a commit to chhzh123/slapo that referenced this pull request Jan 22, 2023
@szhengac @chhzh123
[Bugfix] Fix transformers import order in megatron scripts (awslabs#5)
0876f9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szhengac @comaniac @chhzh123