Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Using None for mpu when PP > 1 #34

Merged
merged 2 commits into from
Feb 1, 2023
Merged

[Bugfix] Using None for mpu when PP > 1 #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27094ca
Using None for mpu when PP > 1
Feb 1, 2023
806c186
lint
Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion slapo/model_dialect/deepspeed/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ def init_ds_engine(model, **kwargs):
raise ValueError("DeepSpeed config not provided.")
mpu = kwargs.get("topology", None)
if mpu is not None and isinstance(mpu, PipeModelDataParallelTopology):
mpu = PipelineParallelGrid(topology=mpu)
if mpu.get_dim("pipe") <= 1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, just for separating the conditions for pipeline and no pipeline in a binary form.

# in the case that pipeline is disabled
mpu = PipelineParallelGrid(topology=mpu)
else:
mpu = None

# pylint: disable=unbalanced-tuple-unpacking
model, optimizer, _, _ = deepspeed.initialize(
Expand Down