This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Updates fix setup scripts and deployment #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Also added the public ecr repo as well as necessary tags into the build script.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo in the current form will not deploy because there are inconsistencies between commands in the README, environment variables set, and the run scripts.
deployment/build-s3-dist.shwhich did not have thePUBLIC_ECR_REGISTRYorPUBLIC_ECR_TAGset. Updated to point to the ecr public repo.s3 cp ...command did not take advantage of the original env variables setup for the S3 bucket. Additionally trimmed off the default profile and bucket ACL items as they are not required.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.