Add metrics for FUSE worker idle and total count #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
force-pushed
the
add-worker-count-metrics
branch
from
8141cfd to
df4b665
Compare
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
reviewed
Feb 11, 2025
|
|
||
| let new_count = old_count + 1; | ||
| let idle_worker_count = self.state.idle_worker_count.fetch_add(1, Ordering::SeqCst) + 1; | ||
| metrics::gauge!(METRIC_NAME_FUSE_WORKERS_TOTAL).set(new_count as f64); |
There was a problem hiding this comment.
Shouldn't this also be set in start?
There was a problem hiding this comment.
It is set when start is called, since start will invoke this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, there was no visibility into how many FUSE worker threads within Mountpoint had been created nor any indication if they are all busy or not.
This change adds both a count for the number of FUSE worker threads that have been spawned, as well as a count measuring how many are currently considered idle.
With the current metric implementation, these are guages and are only emitted when the value is updated. They are emitted in the logs as follows:
Does this change impact existing behavior?
This adds a new metric only.
Does this change need a changelog entry? Does it require a version change?
No, new metric only. Metrics aren't advertised as a stable feature.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).