-
Notifications
You must be signed in to change notification settings - Fork 45
Fork workaround #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork workaround #628
Conversation
test/test_s3.py
Outdated
except Exception as e: | ||
print(f"before_fork error: {e}") | ||
# fail hard | ||
exit(-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exit() just raises an exception (stackoverflow)
and didn't you say exceptions from fork handlers are ignored?
maybe fail harder with os._exit(-1)
... though that wouldn't flush any buffers so we might not see the error. Maybe flush stdout and stderr and then exit hard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/awslabs/aws-crt-python/actions/runs/13904462279/job/38904049353
looks like it flushes the output and makes the exception raised for unittest
but the process still hangs...
…nto fork-workaround
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. Just some questions about the arm64 runners
- name: Build ${{ env.PACKAGE_NAME }} | ||
run: | | ||
aws s3 cp s3://aws-crt-test-stuff/ci/${{ env.BUILDER_VERSION }}/linux-container-ci.sh ./linux-container-ci.sh && chmod a+x ./linux-container-ci.sh | ||
./linux-container-ci.sh ${{ env.BUILDER_VERSION }} aws-crt-manylinux2014-${{ matrix.image }} build -p ${{ env.PACKAGE_NAME }} --python /opt/python/${{ matrix.python }}/bin/python | ||
|
||
manylinux2014-arm64: | ||
runs-on: ubuntu-24.04-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes, but what's up with this in the logs?
Running: SetupCrossCICrtEnvironment
Tests not needed for project. Skipping setting test environment variables
Finished: SetupCrossCICrtEnvironment
Does aws-crt-builder think this is a cross-compile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default, builder doesn't run tests on arm https://github.com/awslabs/aws-crt-builder/blob/main/builder/core/data.py#L318-L329
But, we run our tests via the build action in AWSCrtPython
.
So, it still runs the action, but mqtt stuff was skipped.
Co-authored-by: Michael Graeb <[email protected]>
Issue #, if available:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.