Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cmakejs to devdeps #484

Merged
merged 12 commits into from
Aug 7, 2023
Merged

move cmakejs to devdeps #484

merged 12 commits into from
Aug 7, 2023

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jul 28, 2023

Issue #, if available:

  • Move CmakeJS and tar to devDeps
  • The release pipeline changed since v1.16.0 and made the source private. Anyone tries to fetch source code from S3 will fail

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK changed the title Test dev move cmakejs to devdeps Jul 28, 2023
@TingDaoK TingDaoK marked this pull request as ready for review July 31, 2023 20:46
@TingDaoK TingDaoK merged commit 583d69c into main Aug 7, 2023
@TingDaoK TingDaoK deleted the test-dev branch August 7, 2023 15:39
@TingDaoK TingDaoK mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants