Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel/Pause stream optimization #395

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Cancel/Pause stream optimization #395

merged 7 commits into from
Dec 20, 2023

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Dec 15, 2023

Issue #, if available:

  • We previously cancel/pause meta request by not making any new request, but wait for anything inflight to complete, which doesn't need to happen.
  • We want to cancel streams quickly without waiting for http level

Description of changes:

  • Keep a list of requests that have ongoing http level activities.
  • When cancel or pause invoked, go through the list and cancel the underlying http streams, which will actually cancel the request without waiting for HTTP req/resp to complete.
  • But, for MPU cancel, we still need to wait for abort MPU to complete.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb6af37) 88.69% compared to head (5dc6d7d) 88.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   88.69%   88.72%   +0.02%     
==========================================
  Files          21       21              
  Lines        5962     5986      +24     
==========================================
+ Hits         5288     5311      +23     
- Misses        674      675       +1     
Files Coverage Δ
source/s3_auto_ranged_put.c 92.69% <100.00%> (+0.01%) ⬆️
source/s3_meta_request.c 90.76% <100.00%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

@TingDaoK TingDaoK marked this pull request as ready for review December 18, 2023 19:11
@TingDaoK TingDaoK changed the title Cancel stream Cancel stream optimization Dec 18, 2023
@TingDaoK TingDaoK changed the title Cancel stream optimization Cancel/Pause stream optimization Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants