Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling for failed private key import #259

Closed
wants to merge 2 commits into from
Closed

error handling for failed private key import #259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6673127
error handling for failed private key import
mangelino Mar 31, 2020
ad1bb18
Merge branch 'main' into pkcs_fix_windows
bretambrose Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions source/windows/windows_pki_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,16 @@ int aws_import_key_pair_to_cert_context(
0,
&key,
&decoded_len);

if (!success) {
AWS_LOGF_ERROR(
AWS_LS_IO_PKI,
"static: error decoding PKCS#1 RSA private key for key %s with errno %d",
uuid_str,
(int)GetLastError());
error_code = AWS_OP_ERR;
goto clean_up;
}
HCRYPTKEY h_key = 0;
success = CryptImportKey(crypto_prov, key, decoded_len, 0, 0, &h_key);
LocalFree(key);
Expand Down