Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package templates #2571

Merged
merged 2 commits into from
Feb 10, 2025
Merged

add package templates #2571

merged 2 commits into from
Feb 10, 2025

Conversation

aimethed
Copy link
Contributor

@aimethed aimethed commented Feb 3, 2025

Description of changes:
For all connectors that have jar/zip files small enough to be deployed directly to lambda, the templates are being added back. These templates will not be deployed to standard partition regions but can be used to manually deploy the connectors.

Snowflake and Bigquery connector zip/jar files are too large. GCS and Vertica connector zip/jar files are very close, so they are included for now to test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.68%. Comparing base (f3521ad) to head (3b67035).
Report is 41 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2571      +/-   ##
============================================
- Coverage     60.68%   60.68%   -0.01%     
  Complexity     3871     3871              
============================================
  Files           593      593              
  Lines         22130    22129       -1     
  Branches       2732     2732              
============================================
- Hits          13430    13429       -1     
  Misses         7398     7398              
  Partials       1302     1302              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aimethed
Copy link
Contributor Author

aimethed commented Feb 7, 2025

PR where the teradata was initially removed: https://github.com/awslabs/aws-athena-query-federation/pull/2294/files

GCS and Vertica were tested and the unzipped size was too large, so the templates have been removed.

@ejeffrli ejeffrli merged commit a2bbb2f into master Feb 10, 2025
10 checks passed
@ejeffrli ejeffrli deleted the package-templates branch February 10, 2025 16:42
github-actions bot pushed a commit that referenced this pull request Feb 10, 2025
  - Remove endpoint (#2574)
  - add package templates (#2571)
  - Upgraded Github Action to JDK 11 (#2586)
  - build(deps): bump com.google.cloud:google-cloud-storage from 2.48.0 to 2.48.1 (#2578)
  - build(deps): bump com.google.cloud:google-cloud-storage
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.18.2 to 3.19 (#2579)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier
  - build(deps): bump com.microsoft.azure:msal4j from 1.18.0 to 1.19.0 (#2581)
  - build(deps): bump com.microsoft.azure:msal4j from 1.18.0 to 1.19.0
  - build(deps): bump com.github.spotbugs:spotbugs-annotations from 4.9.0 to 4.9.1 (#2585)
  - build(deps): bump com.github.spotbugs:spotbugs-annotations
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.23.8 to 2.23.9 (#2582)
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.23.8 to 2.23.9
  - build(deps): bump com.oracle.database.jdbc:ojdbc8 from 23.6.0.24.10 to 23.7.0.25.01 (#2583)
  - build(deps): bump com.oracle.database.jdbc:ojdbc8
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.30.11 to 2.30.16 (#2580)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs
  - build(deps): bump aws-sdk-v2.version from 2.30.11 to 2.30.16 (#2577)
  - build(deps): bump aws-sdk-v2.version from 2.30.11 to 2.30.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants