Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Arrow version upgrade to 15.0.2 #2364

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Trianz-Akshay
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Apache Arrow version upgrade to 15.0.2
  • unit test case : (Unmapped JDBC type: 2014)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

<artifactId>bcprov-jdk15on</artifactId>
<version>1.70</version>
<artifactId>bcprov-jdk18on</artifactId>
<version>1.78.1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check if bouncy castle are part of shaded jar? if no, can we included it in and relocate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bouncy Castle was already included in the shaded JAR; I have now relocated the class path to prevent any conflicts.

Copy link
Contributor

@AbdulR3hman AbdulR3hman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have we performed tests on JDBC connectors?

we are dependent on arrow-jdbc which is very important for our JDBC-based connector where we depend on that library to convert types.

@@ -41,6 +41,10 @@
<groupId>software.amazon.awssdk</groupId>
<artifactId>netty-nio-client</artifactId>
</exclusion>
<exclusion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this won't be needed once #2555 is merged.

@@ -183,7 +183,7 @@ public void doGetTable()
BlockAllocator blockAllocator = new BlockAllocatorImpl();
String[] schema = {"DATA_TYPE", "COLUMN_SIZE", "COLUMN_NAME", "DECIMAL_DIGITS", "NUM_PREC_RADIX"};
Object[][] values = {{Types.INTEGER, 12, "testCol1", 0, 0}, {Types.VARCHAR, 25, "testCol2", 0, 0},
{Types.TIMESTAMP, 93, "testCol3", 0, 0}, {Types.TIMESTAMP_WITH_TIMEZONE, 93, "testCol4", 0, 0}};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a big difference, is arrow no longer supporting TIMESTAMP with Timezone?

@Trianz-Akshay
Copy link
Contributor Author

have we performed tests on JDBC connectors?

we are dependent on arrow-jdbc which is very important for our JDBC-based connector where we depend on that library to convert types.

This PR is part of CVE fix.
As discussed earlier, the CVE issues were resolved with the SDK v2 update, making this PR unnecessary.

For your reference, please find the link to our previous Slack discussion: https://trianzappflow.slack.com/archives/C06NFCG7XUJ/p1731668318687099?thread_ts=1729522952.540769&cid=C06NFCG7XUJ

Kindly proceed with closing this open PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants