-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apache Arrow version upgrade to 15.0.2 #2364
base: master
Are you sure you want to change the base?
Conversation
<artifactId>bcprov-jdk15on</artifactId> | ||
<version>1.70</version> | ||
<artifactId>bcprov-jdk18on</artifactId> | ||
<version>1.78.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please check if bouncy castle are part of shaded jar? if no, can we included it in and relocate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bouncy Castle was already included in the shaded JAR; I have now relocated the class path to prevent any conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we performed tests on JDBC connectors?
we are dependent on arrow-jdbc
which is very important for our JDBC-based connector where we depend on that library to convert types.
@@ -41,6 +41,10 @@ | |||
<groupId>software.amazon.awssdk</groupId> | |||
<artifactId>netty-nio-client</artifactId> | |||
</exclusion> | |||
<exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this won't be needed once #2555 is merged.
@@ -183,7 +183,7 @@ public void doGetTable() | |||
BlockAllocator blockAllocator = new BlockAllocatorImpl(); | |||
String[] schema = {"DATA_TYPE", "COLUMN_SIZE", "COLUMN_NAME", "DECIMAL_DIGITS", "NUM_PREC_RADIX"}; | |||
Object[][] values = {{Types.INTEGER, 12, "testCol1", 0, 0}, {Types.VARCHAR, 25, "testCol2", 0, 0}, | |||
{Types.TIMESTAMP, 93, "testCol3", 0, 0}, {Types.TIMESTAMP_WITH_TIMEZONE, 93, "testCol4", 0, 0}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a big difference, is arrow no longer supporting TIMESTAMP with Timezone?
This PR is part of CVE fix. For your reference, please find the link to our previous Slack discussion: https://trianzappflow.slack.com/archives/C06NFCG7XUJ/p1731668318687099?thread_ts=1729522952.540769&cid=C06NFCG7XUJ Kindly proceed with closing this open PR. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.