Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout #337

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Increase timeout #337

merged 3 commits into from
Aug 8, 2018

Conversation

icywang86rui
Copy link
Contributor

@icywang86rui icywang86rui commented Aug 7, 2018

Issue #, if available:

Description of changes:

Hosting team advised us to increase the timeout to 45 minutes to avoid test failures.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@icywang86rui icywang86rui requested a review from yangaws August 7, 2018 21:34
setup.py Outdated
@@ -23,7 +23,7 @@ def read(fname):


setup(name="sagemaker",
version="1.9.0",
version="1.9.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we change the version here? We are not going to release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. You are right. I will remove this. We do not need to release to fix the tests.

Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icywang86rui icywang86rui merged commit 7baf682 into aws:master Aug 8, 2018
@yangaws yangaws mentioned this pull request Aug 10, 2018
4 tasks
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
* Change timeout to 45 minutes for createEndpoint in integ tests
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Changed the value of label_width to 600 to handle full coco dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants