Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): make the awslc fips install script version aware #5100

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Feb 8, 2025

Release Summary:

Resolved issues:

none

Description of changes:

AWS Libcrypto FIPS 3.0 needs to be part of our testing. This PR makes converts the 2022 installer into a symlink, with the underlying script choosing the feature branch based on the command name. This is an attempt at anticipating future versions of lc.

Call-outs:

The original awslc install script, which installs the 2021/v1 FIPS code, was not altered.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? locally

Remember:

  • Any change to the library source code should at least include unit tests.
  • Any change to the core stuffer or blob methods should include CBMC proofs.
  • Any change to the CI or tests should:
    1. prove that the test succeeds for good input
    2. prove that the test fails for bad input (eg, a test for memory leaks fails when a memory leak is committed)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Feb 8, 2025
@dougch dougch requested review from goatgoose and lrstewart February 8, 2025 00:22
@dougch dougch marked this pull request as ready for review February 11, 2025 17:30
@dougch dougch requested a review from lrstewart February 13, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants