ci: improve output of validate_start_codebuild_script #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Description of changes:
@jmayclin was understandably confused by the output of a run that failed bc no codebuild jobs started: https://github.com/aws/s2n-tls/actions/runs/12756626358/job/35555159619 The lack of newlines made the difference between the two lists + the diff confusing. I also figured this will be a common failure case, so added a very explicit error.
Testing:
For the success case, you can see the output of the job on this PR: https://github.com/aws/s2n-tls/actions/runs/12759774029/job/35564091297?pr=5031
For the failure case, I opened a PR with these changes that also triggered no codebuild jobs: https://github.com/aws/s2n-tls/actions/runs/12759818434/job/35564200785?pr=5032
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.