chore: improve the dashboard comment query #5016
Conversation
.github/workflows/dashboard.yml
Outdated
| title: 'No comment (external) last 14 days' | ||
| issue_query: 'repo:aws/s2n-tls is:open is:pr comments:0 -label:status/stale -label:s2n-core created:>{{ date("-14 days") }}' |
There was a problem hiding this comment.
What IS the "issue_query" distinction between comments and reviews? By looking for comments, are we now missing whatever "review" was? Or is it an "all reviews are comments, but not all comments are reviews" kind of situation?
There was a problem hiding this comment.
What IS the "issue_query" distinction between comments and reviews? By looking for comments, are we now missing whatever "review" was? Or is it an "all reviews are comments, but not all comments are reviews" kind of situation?
In the PR history, the banner on the update says 'review' or 'comment',
Doing a few trial queries, I'm going to say review:none by itself doesn't work. comments:0 does appear to work on it's own, as does combining the two (?!?).
- Both search terms 3 results, all matching the search
- just comment:0 6 results, all appear the match the search
- just review:none 34 results, but not correct, e.g. tests: make integV2 locally runnable #5029 which has a review
There was a problem hiding this comment.
From that, it seems like a "review" is approve (and probably "request changes"). Like #5025 shows up in your "comment:0" search because it just got approvals, no comments. So it seems to me like what we want is both search terms?
There was a problem hiding this comment.
From that, it seems like a "review" is approve (and probably "request changes"). Like #5025 shows up in your "comment:0" search because it just got approvals, no comments. So it seems to me like what we want is both search terms?
Agreed- let me update it.
Release Summary:
Resolved issues:
n/a
Description of changes:
Our original GitHub dashboard has a "No review" block that should actually be PRs that have no comment, update the query.
Call-outs:
The distinction between review and comment is a bit pedantic.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? tested using the GitHub Query https://github.com/search?q=repo%3Aaws%2Fs2n-tls+is%3Aopen+is%3Apr+comments%3A0+-label%3Astatus%2Fstale+-label%3As2n-core&type=pullrequests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.