Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move kTLS test out of GeneralBatch #4904

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Nov 19, 2024

Release Summary:

Resolved issues:

n/a

Description of changes:

Replaces #4886. CodeBuild now supports ec2 instance types, move kTLS out of general batch and onto this new setup. Example run: here

Because this new CodeBuild feature does not support batch builds, I've added the kTLS ASAN job to the new kTLS buildspec serially. On the 8vcpu instance, total runtime is ~8 minutes, end to end.

Call-outs:

This moves us away from hand rolled QEMU VM images and onto a vended AL2023 AMI.

This change also directly uses the Nix s3 cache to speed up builds.

Release steps:

  • While this is in review, I'll finalize the CodeBuild job
  • Just prior to merging, the webhook will be turned on in "not required" mode.
  • After some soak time, we'll mark it required

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? On a new job called AMI Tester, see the linked run above
How can you convince your reviewers that this PR is safe and effective? ad-hoc test run, you can duplicate in AMI tester
Is this a refactor change? of s2n code, no, of CI, yes. No more Qemu or AL2 qcow images.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Nov 19, 2024
@dougch dougch marked this pull request as ready for review November 19, 2024 18:17
@dougch dougch requested review from lrstewart and jmayclin November 19, 2024 18:17
@dougch
Copy link
Contributor Author

dougch commented Nov 20, 2024

To confirm this change catches leaks, I ran this PR, with this patch applied and confirmed the new CodeBuild job fails.

@dougch dougch enabled auto-merge (squash) November 20, 2024 20:35
@dougch dougch merged commit d9df784 into aws:main Nov 20, 2024
39 checks passed
@dougch dougch deleted the ktls_goes_brrrr branch January 15, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants