ci: Move kTLS test out of GeneralBatch #4904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
Replaces #4886. CodeBuild now supports ec2 instance types, move kTLS out of general batch and onto this new setup. Example run: here
Because this new CodeBuild feature does not support batch builds, I've added the kTLS ASAN job to the new kTLS buildspec serially. On the 8vcpu instance, total runtime is ~8 minutes, end to end.
Call-outs:
This moves us away from hand rolled QEMU VM images and onto a vended AL2023 AMI.
This change also directly uses the Nix s3 cache to speed up builds.
Release steps:
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? On a new job called AMI Tester, see the linked run above
How can you convince your reviewers that this PR is safe and effective? ad-hoc test run, you can duplicate in AMI tester
Is this a refactor change? of s2n code, no, of CI, yes. No more Qemu or AL2 qcow images.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.