fix: add missing null-checks in s2n_connection.c #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4752
Description of changes:
I initially planned to fix the missing null-check for
s2n_connection_wipe_keys, but while reviewing the file, I found other functions missing null-checks, which could potentially lead to null-pointer errors.I added null-checks to functions that didn't perform them. For cases where a function calls another function that already performs a null-check, I did not add additional checks.
Testing:
Unit tests passed. Will address CI failures if any.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.