-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci:Al2023 CodeBuild script #4737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should one file do both installs, and should that file still be called "al2"? Maybe you need a separate install_al_dependencies for the common dependencies, or just need to rename this file?
Or was the plan to rename this file to install_al_dependencies in a follow-up PR, and you just left the name as-is for now for a nice diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that the name needs update, yes- separating the buildspec PR helps me make sure I'm not breaking any existing tests.
Co-authored-by: Lindsay Stewart <[email protected]>
Co-authored-by: Lindsay Stewart <[email protected]>
Resolved issues:
Partial for #4681
Description of changes:
Add AmazonLinux 2023 to our CI. Our existing AL2 setup script is close enough that I've opted to just have that script do both versions.
Call-outs:
As with AL2, this setup is only for unit tests. This setup currently only runs Openssl 3.0 tests, a future PR can include more libcrypto's.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally and with an ad-hoc job, which partially duplicates the CI, but with updated AL2 CodeBuild Images (we're using the older v2 image, moving to 3
also...
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.