Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci:Al2023 CodeBuild script #4737

Merged
merged 10 commits into from
Sep 5, 2024
Merged

ci:Al2023 CodeBuild script #4737

merged 10 commits into from
Sep 5, 2024

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Aug 27, 2024

Resolved issues:

Partial for #4681

Description of changes:

Add AmazonLinux 2023 to our CI. Our existing AL2 setup script is close enough that I've opted to just have that script do both versions.

Call-outs:

As with AL2, this setup is only for unit tests. This setup currently only runs Openssl 3.0 tests, a future PR can include more libcrypto's.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? locally and with an ad-hoc job, which partially duplicates the CI, but with updated AL2 CodeBuild Images (we're using the older v2 image, moving to 3

also...

docker run -tiv $(pwd):/opt/s2n-tls public.ecr.aws/amazonlinux/amazonlinux:2023 /bin/bash
cd /opt/s2n-tls
./codebuild/bin/install_al2_dependencies.sh
(cmake build/test commands as usual)

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Aug 27, 2024
@dougch dougch marked this pull request as ready for review August 28, 2024 19:46
@dougch dougch requested review from lrstewart and goatgoose August 28, 2024 19:46
@dougch dougch changed the title ci:Al2023 setup steps ci:Al2023 CodeBuild script Aug 28, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should one file do both installs, and should that file still be called "al2"? Maybe you need a separate install_al_dependencies for the common dependencies, or just need to rename this file?

Or was the plan to rename this file to install_al_dependencies in a follow-up PR, and you just left the name as-is for now for a nice diff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that the name needs update, yes- separating the buildspec PR helps me make sure I'm not breaking any existing tests.

codebuild/bin/install_al2_dependencies.sh Outdated Show resolved Hide resolved
codebuild/bin/install_al2_dependencies.sh Outdated Show resolved Hide resolved
codebuild/bin/install_al2_dependencies.sh Show resolved Hide resolved
codebuild/bin/install_al2_dependencies.sh Outdated Show resolved Hide resolved
docs/BUILD.md Outdated Show resolved Hide resolved
codebuild/bin/install_al2_dependencies.sh Outdated Show resolved Hide resolved
@dougch dougch enabled auto-merge (squash) September 4, 2024 22:28
@dougch dougch merged commit 9738cc7 into aws:main Sep 5, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants