fix: upload fuzz output to s3 when test fails #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougch
approved these changes
Aug 7, 2024
| fi | ||
|
|
||
| # Store generated output files in the S3 bucket. | ||
| if [ "$ARTIFACT_UPLOAD_LOC" != "none" ]; then |
There was a problem hiding this comment.
Curious where $ARTIFACT_UPLOAD_LOC is getting set? In the job definition?
There was a problem hiding this comment.
Yes, it's defined by environment variable in the job.
camshaft
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
There was a mistake in #4678
The output is being uploaded to s3 when the test is "negative" (e.g. running
s2n_memory_leak_negative_test.c)Instead it should be uploaded when the test actually fails.
Description of changes:
The output will be uploaded to s3 when the test fails, not when the test is negative
Call-outs:
Testing:
Test run with the new batch build: link to CodeBuild job
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.