feat: JA4 fingerprinting #4669
Merged
feat: JA4 fingerprinting #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
ja4_3
branch
2 times, most recently
from
248468f to
cde66c8
Compare
goatgoose
reviewed
Aug 2, 2024
goatgoose
reviewed
Aug 6, 2024
goatgoose
approved these changes
Aug 9, 2024
lrstewart
requested review from
goatgoose and
maddeleine
and removed request for
camshaft
goatgoose
approved these changes
Aug 9, 2024
maddeleine
reviewed
Aug 13, 2024
maddeleine
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add the JA4 fingerprinting algorithm: https://github.com/FoxIO-LLC/ja4/blob/v0.18.2/technical_details/JA4.md
Call-outs:
It's not as many files to review as it looks like: I imported the JA4 "spec" from github for duvet, which is most of the files. I actually generated the spec requirements too instead of hand writing them, although I had to modify duvet to make that work. I made duvet interpret every line as a requirement, then went back and deleted the requirements that didn't make sense.
Testing:
Unit tests. I also locally added JA4 to the "pcap" crate tests, but I didn't want to made this PR any bigger by including that here. I'll have a follow-up PR with more testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.