-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl3 integration: workaround for new EVP_Cipher return code #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
loqs
reviewed
Aug 25, 2022
maddeleine
reviewed
Aug 25, 2022
087808c
to
b4abd23
Compare
franklee26
reviewed
Aug 25, 2022
franklee26
approved these changes
Aug 25, 2022
lrstewart
reviewed
Aug 26, 2022
maddeleine
approved these changes
Aug 26, 2022
10df1fc
to
5b21395
Compare
5b21395
to
58e6930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In openssl3 EVP_Cipher checks if a provider has been set and then introduces different functionality:
So based on the source code, openssl3 now checks if there is a provider (cipher→prov) set on the ctx and based on that triggers the new behavior.
Fix1 (recommended):
A solution is to use
EVP_EncryptUpdate
andEVP_DecryptUpdate
as is done in the other cipher implemenations: code.pros:
Fix2:
Since in ossl3 we load the "default" and "legacy" providers, we can assume and handle the new return code behavior.
This however introduces the need for
ifdef
which makes the code more complicated to reason about.Testing:
Locally unit test passes in ossl3 and also ossl2 locally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.