Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on OCSP functionality for AWS-LC #3058

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Conversation

samuel40791765
Copy link
Contributor

Resolved issues:

Resolves missing OCSP support for s2n from AWS-LC

Description of changes:

With aws/aws-lc#245 merged, this PR enables S2N_OCSP_STAPLING_SUPPORTED when OPENSSL_IS_AWSLC is defined.

Call-outs:

N/A

Testing:

CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test coverage in x509_validator_test

@@ -23,7 +23,7 @@

/* one day, BoringSSL/AWS-LC, may add ocsp stapling support. Let's future proof this a bit by grabbing a definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated :)

@dougch dougch merged commit 279a749 into aws:main Sep 21, 2021
@samuel40791765 samuel40791765 deleted the aws-lc-ocsp branch December 1, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants