ci: specify specific bolero dependency rather than workspace dependency #2424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Dependabot for
s2n-quic
is currently down with this error message. I checked the dependabot update log and found this error message:Seems like the Dependabot can't resolve dependency that we are currently doing in
s2n-quic
:s2n-quic/Cargo.toml
Lines 18 to 20 in 5dd0c47
s2n-quic/quic/s2n-quic-transport/Cargo.toml
Lines 31 to 33 in 5dd0c47
This problem is also mentioned in Dependabot-core repo:
They to implement features to support workspace in dependabot, but later reverted the change due to regression: dependabot/dependabot-core#10550 (comment).
They then try to reimplement such feature, but hasn't merge it: dependabot/dependabot-core#10629.
We do want to use
workspace
for this library in the future as mentioned in a previous PR#2400. However, we want to fix dependabot for now.Therefore, this PR remove
workspace
in Cargo.toml and ping version 0.12 for bolero dependency. We believe such change could potentially fix our dependabot.Call-outs:
This PR can only be tested after merge. Dependabot should be triggered again on this PR is merge, and we will see whether this fix it or not. If not, then we need to revert this change and investigate other causes and solutions.
We can still use workspace dependency if the dependabot team merge their PR.
Testing:
Merge this PR to test dependabot.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.