fix(ci): fix the release #2423
Merged
fix(ci): fix the release #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The release check in CI won't load credential if the PR is created from a forked
s2n-quicrepo. The error report is in this test result. Therefore, we should add a check to load the credential.Testing:
This PR is created from @boquan-fang's forked
s2n-quicrepo. We test this PR with the release qns test in the CI to see whether it actually works.The test result is here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.