fix(s2n-quic-dc): make debug assertions cheaper for TCP accept manager #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/dc-debug-opt
branch
from
7d3cae6 to
f7e3e71
Compare
| .chain(self.by_sojourn_time.iter(&self.workers)) | ||
| .collect::<Vec<_>>(); | ||
| linked_workers.sort(); | ||
| assert!((0..self.workers.len()).eq(linked_workers.iter().copied())); |
There was a problem hiding this comment.
We probably need an assert! that the linked_workers has the same length? I guess sort of implies with free.iter, but maybe doesn't hurt?
There was a problem hiding this comment.
Iterator::eq should also check the length: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.eq
assert_eq!([1].iter().eq([1].iter()), true);
assert_eq!([1].iter().eq([1, 2].iter()), false);There was a problem hiding this comment.
Hm, I'm distinctly remembering some kind of oops around this... maybe just bad memory.
There was a problem hiding this comment.
I had the same memory at first. There are some that so have that issue, like zip.
Mark-Simulacrum
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The current
invariantscheck intcp::tokio::managerends up being quite expensive, especially when the backlog is large - basicallyO(N^2). Instead, I made them collect all of the indexes into a vec and sort them before comparing. This ends up being quite a bit cheaper than what we were doing before.I also made a slight change to the free list behavior. Instead of pushing back free workers it pushes them to the front. The effect is that we only end up using N workers, where N is the number of concurrent connections. In theory, this should reduce memory churn, though it might be overall quite small. But I thought it couldn't hurt.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.