Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump the envtest default version to 1.28.x #5109

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Nov 17, 2023

Fixes #N/A

Description

This change bumps the toolchain.sh version of envtest to 1.28.x so that it matches the version that is used over in karpenter-core: https://github.com/aws/karpenter-core/blob/main/hack/toolchain.sh#L4

arm64/darwin is now supported by kubebuilder as described here: kubernetes-sigs/kubebuilder#2785, kubernetes-sigs/kubebuilder#1932 (comment)

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner November 17, 2023 19:23
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit df356b6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6557bda5f41d40000892a458

@jonathan-innis jonathan-innis enabled auto-merge (squash) November 17, 2023 19:37
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit b92352a into aws:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants