Skip to content

Commit

Permalink
Update v1alpha6.md
Browse files Browse the repository at this point in the history
  • Loading branch information
ellistarn committed Jan 17, 2023
1 parent 7f1875a commit a006925
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions designs/v1alpha6.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Naming confusion:
Currently fields that control node properties, such as Labels, Taints, StartupTaints, Requirements, Kubelet, ProviderRef, are top level members of provisioner.spec. These are siblings of fields that control provisioning behavior, such as Limits, TTLSecondsUntilExpired, and Weight.

Instead, we should separate out properties of the node in the same way that pod properties are separated from their parent controllers. This has a nice effect of simultaneously creating a place for users to define node metadata. This design mirrors that of kubernetes objects that contain podtemplatespecs, like Deployment, StatefulSet, Job, and CronJob.

```
spec:
ttlSecondsUntilExpired: ...
weight: ...
Expand All @@ -69,6 +69,7 @@ spec:
requirements: ...
kubelet: ...
providerRef: ...
```

### Rename: kubeletConfiguration → kubelet

Expand All @@ -80,7 +81,7 @@ We’ve recommended that customers leverage spec.providerRef in favor of spec.pr

### Deprecate: awsnodetemplate.spec.launchTemplate

Direct launch template support is problematic for many reasons, outlined in the [design])https://github.com/aws/karpenter/blob/main/designs/aws/aws-launch-templates-v2.md). Customers continue to run into issues when directly using launch templates. From many conversations with customers, our AWSNodeTemplate design has achieved feature parity with launch templates. The only gap is for users who maintain external workflows for launch template management. This requirement is in direct conflict with users who run into this sharp edge.
Direct launch template support is problematic for many reasons, outlined in the [design](https://github.com/aws/karpenter/blob/main/designs/aws/aws-launch-templates-v2.md). Customers continue to run into issues when directly using launch templates. From many conversations with customers, our AWSNodeTemplate design has achieved feature parity with launch templates. The only gap is for users who maintain external workflows for launch template management. This requirement is in direct conflict with users who run into this sharp edge.

This change simply removes legacy support for launch templates in favor of the AWSNodeTemplate design.

Expand Down

0 comments on commit a006925

Please sign in to comment.