Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
VertexId
andEdgeId
value to include a prefix that represents the original type of the ID before being mapped in to Graph Explorer.(num)1234
(str)a6ca3117-92e7-10d4-5c52-a6e0fa16862d
Why?
The ID type is important for different Gremlin server implementations. Neptune is always a string, while the default for Gremlin Server and Janus Graph is a number.
When we implement URL sharing, or other forms of sharing, where the ID must be serialized to a string value we will want a way to determine if the original value was a number or a string.
In order to avoid any potential conflicts with user data string values, this type serialization is being applied judiciously so that it can be assumed to exist.
Next Steps
Vertex.idType
andEdge.idType
VertexRef
andEdgeRef
Validation
Related Issues
Check List
license.
pnpm checks
to ensure code compiles and meets standards.pnpm test
to check if all tests are passing.Changelog.md
.