Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the next 10 neighbors #455

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 25, 2024

Description

When the user double clicks a node GE will now expand the next 10 nodes.

Before it would check if the neighbors count is greater than 10. If it is, then show the expand sidebar. If not, it expands.

Now it will always expand, but at most 10 items.

Validation

  • Verified with all three query engines
    • SPARQL still needs work on the query side, but that is happening in a different branch

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 25, 2024 01:54
@kmcginnes kmcginnes marked this pull request as ready for review June 25, 2024 01:54
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 14.85%. Comparing base (361c4ba) to head (b06c1f0).
Report is 45 commits behind head on main.

Current head b06c1f0 differs from pull request most recent head 1719c06

Please upload reports for the commit 1719c06 to get more accurate results.

Files Patch % Lines
...h-explorer/src/modules/GraphViewer/GraphViewer.tsx 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   13.97%   14.85%   +0.87%     
==========================================
  Files         414      419       +5     
  Lines       30639    30948     +309     
  Branches      878      967      +89     
==========================================
+ Hits         4283     4596     +313     
+ Misses      26026    26023       -3     
+ Partials      330      329       -1     
Flag Coverage Δ
unittests 14.85% <0.00%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmcginnes kmcginnes merged commit b53a6d4 into aws:main Jun 26, 2024
1 check passed
@kmcginnes kmcginnes deleted the paging-double-click branch June 26, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants