Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Query v3 to TanStack Query v5 #360

Merged
merged 6 commits into from
May 8, 2024

Conversation

kmcginnes
Copy link
Collaborator

Updates the app to use TanStack Query v5 instead of React Query v3.

There were a decent number of breaking changes in these versions. Luckily, our app doesn't use React Query extensively, so there were only a few areas that needed close attention.

Discovered Bug

I also noticed and fixed a bug related to the vertex count logic. If you start on the connections screen and do a fresh sync you'll see the total node & edge counts. Then go in to one of the node types in the data explorer. When you come back to the connection screen the total counts are zeroed out.

This issue existed before the changes in this PR. But I fixed it anyway.

Validation

  • Verify query and paging works in the data explorer
  • Verify keyword search in graph explorer works
  • Verify vertex counts are properly updated

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@kmcginnes kmcginnes requested a review from vkagamlyk May 8, 2024 20:29
@kmcginnes kmcginnes marked this pull request as ready for review May 8, 2024 20:29
@kmcginnes kmcginnes merged commit 00caf96 into aws:main May 8, 2024
1 check passed
@kmcginnes kmcginnes deleted the update-react-query branch May 8, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Update libraries Update React Query (now called "TanStack Query")
2 participants