-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stack): add Firelens sidecar deployment support #992
feat(stack): add Firelens sidecar deployment support #992
Conversation
cb3c6e2
to
5378de4
Compare
Manual TestPermission fileAdditionalResourcesPolicy:
Type: AWS::IAM::ManagedPolicy
Properties:
PolicyDocument:
Version: 2012-10-17
Statement:
- Effect: Allow
Action:
- logs:CreateLogStream
- logs:CreateLogGroup
- logs:DescribeLogStreams
- logs:PutLogEvents
Resource: "*" Not using config filemanifest logging:
destination:
Name: cloudwatch
region: us-west-2
log_group_name: /copilot/my-project-test-my-app
log_stream_prefix: copilot/ Using config filemanifest logging:
image: 403971813171.dkr.ecr.us-west-2.amazonaws.com/fluentbit:latest
configFilePath: /extra.conf config file
output from svc logsWith ECS meta data
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
5378de4
to
cee1744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the SvcLogsOutput
in the e2e/outputs.go plz? Since we renamed TaskID
cee1744
to
c56e9b2
Compare
Fixed broken e2e test because of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! <3
Partially address #875. With this PR now we can deploy a Copilot service with Firelens as the log driver to deliver logs of the main container to destinations.
Users can config Firelens in two ways:
Additionally users might need to add permissions to task role if necessary. And they are able to add their own permissions by using Copilot addons feature. Any addons policy will be added to the task role.
This PR also adjusts
svc logs
to accommodate Firelens changes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.