-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add app show support for backend app #876
feat(cli): add app show support for backend app #876
Conversation
Can we remove the http from the service discovery endpoint? |
I'll pull your branch and test it with my WIP |
Your command works!
|
YAY! |
var d *describe.WebAppDescriber | ||
var err error | ||
} | ||
opts.initDescriber = func(enableResources bool) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we add more patterns we might want this to be a describer provider or something that can look up the right functions in a map or something like that - so we don't end up with one giant function. We needn't do it now, but just a note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. That's a good idea!
With this change
app show
now should be able to show running backend applications. However, we cannot test this feature manually untilapp deploy
supports deploying backend app.Ideally the output for app show for backend app should be:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.