refactor: DeployApp accepts an interface instead of cfn primitives #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All application stacks need to implement the stack.StackConfiguration interface. By having DeployApp" accept that interface we can have the method deploy any type of application.
|
Ran e2e tests and they pass ✅ |
| // DeployApp deploys an application stack and waits until the deployment is done. | ||
| // If the application doesn't exist, then it creates the stack. | ||
| // If the application already exists, it updates the stack. | ||
| func (cf CloudFormation) DeployApp(conf StackConfiguration, opts ...cloudformation.StackOption) error { |
kohidave
approved these changes
Apr 20, 2020
| workspaceService wsAppReader | ||
| ecrService ecrService | ||
| dockerService dockerService | ||
| s3Service artifactPutter |
There was a problem hiding this comment.
just a tiny thing - can we call this artifactUploader or artifactStorer?
There was a problem hiding this comment.
I'll incorporate this in the next PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All application stacks need to implement the cloudformation.StackConfiguration
interface. By having "DeployApp" accept that interface we can have the
method deploy any type of application.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.