fix(e2e): quick fix to e2e test #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhopaul123
requested review from
kohidave,
efekarakus,
bvtujo,
SoManyHs and
a team
iamhopaul123
force-pushed
the
env-init/e2e_fix
branch
2 times, most recently
from
4279906 to
7078e1d
Compare
efekarakus
reviewed
Mar 24, 2020
iamhopaul123
force-pushed
the
env-init/e2e_fix
branch
from
7078e1d to
6fff5a4
Compare
efekarakus
approved these changes
Mar 24, 2020
efekarakus
reviewed
Mar 24, 2020
| @@ -156,6 +156,7 @@ func (o *initEnvOpts) Execute() error { | |||
| if err != nil { | |||
| return fmt.Errorf("get environment struct for %s: %w", o.EnvName, err) | |||
| } | |||
| env.Prod = o.IsProduction | |||
There was a problem hiding this comment.
can we add a unit test for this? where the GetEnvironment returns an env.Prod = false and we set it to true
efekarakus
approved these changes
Mar 25, 2020
kohidave
approved these changes
Mar 25, 2020
iamhopaul123
force-pushed
the
env-init/e2e_fix
branch
from
b0ec79e to
14c7aa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken e2e test after #763.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.