Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if docker is running should work for windows #5660

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

iamhopaul123
Copy link
Contributor

Fixes #5656

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner February 6, 2024 19:14
@iamhopaul123 iamhopaul123 requested review from efekarakus and removed request for a team February 6, 2024 19:14
Copy link

github-actions bot commented Feb 6, 2024

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 57536 57312 +0.39
macOS (arm) 58580 58332 +0.43
linux (amd) 50444 50252 +0.38
linux (arm) 49728 49540 +0.38
windows (amd) 47516 47340 +0.37

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d3b36ac) 93.25% compared to head (e7b7cf2) 70.03%.

Files Patch % Lines
internal/pkg/docker/dockerengine/dockerengine.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           mainline    #5660       +/-   ##
=============================================
- Coverage     93.25%   70.03%   -23.22%     
=============================================
  Files            14      303      +289     
  Lines          1630    46628    +44998     
  Branches        299      299               
=============================================
+ Hits           1520    32658    +31138     
- Misses          105    12384    +12279     
- Partials          5     1586     +1581     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KollaAdithya
Copy link
Contributor

we have some other places where we are running similar sort of commands in the codebase to access a particular object in json format, for example over here and here

Is the Output format is same in both windows, mac and linux when accessing individual object.
Do we need to verify this as well.

we need @CaptainCarpensir help for this 😄

@iamhopaul123
Copy link
Contributor Author

we have some other places where we are running similar sort of commands in the codebase to access a particular object in json format, for example over here and here

Is the Output format is same in both windows, mac and linux when accessing individual object. Do we need to verify this as well.

we need @CaptainCarpensir help for this 😄

Good call! We def. need his help before merging this PR. The root problem is for windows docker info gives an extra line before the json. If the other docker command doesn't have similar issue we are probably good for now.

@iamhopaul123
Copy link
Contributor Author

Tested offline on my windows PC and it seems finally working!

@mergify mergify bot merged commit 5ee9a70 into aws:mainline Feb 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Problem with Docker
4 participants