docs: run local container dependencies blogpost #5598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KollaAdithya
requested review from
CaptainCarpensir
and removed request for
a team
|
🍕 Here are the new binary sizes!
|
CaptainCarpensir
approved these changes
Jan 9, 2024
dannyrandall
reviewed
Jan 9, 2024
| ``` | ||
|
|
||
| This means that your main container will start only after nginx sidecar container has started and nginx will start only after startup container is completed successfully. |
There was a problem hiding this comment.
i feel like we should show the startup container in this example?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mainline #5598 +/- ##
============================================
- Coverage 70.01% 70.01% -0.01%
============================================
Files 302 303 +1
Lines 46534 46584 +50
Branches 299 299
============================================
+ Hits 32579 32614 +35
- Misses 12370 12384 +14
- Partials 1585 1586 +1 ☔ View full report in Codecov by Sentry. |
iamhopaul123
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.