Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for ubuntu based distro to install ssm plugin #5571

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

KollaAdithya
Copy link
Contributor

related #2561

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya KollaAdithya requested a review from a team as a code owner December 18, 2023 17:15
@KollaAdithya KollaAdithya requested review from huanjani and removed request for a team December 18, 2023 17:15
Copy link

github-actions bot commented Dec 18, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56932 56796 +0.24
macOS (arm) 57964 57796 +0.29
linux (amd) 49924 49804 +0.24
linux (arm) 49152 49092 +0.12
windows (amd) 47048 46940 +0.23

@KollaAdithya KollaAdithya changed the title fix: change logic for checking ubuntu based distro fix: check for ubuntu based distro to install ssm plugin Dec 18, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9bc5f46) 70.00% compared to head (417ae1a) 70.02%.
Report is 2 commits behind head on mainline.

Files Patch % Lines
...pkg/exec/ssm_plugin_install_latest_binary_linux.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5571      +/-   ##
============================================
+ Coverage     70.00%   70.02%   +0.01%     
============================================
  Files           302      302              
  Lines         46403    46417      +14     
  Branches        301      301              
============================================
+ Hits          32486    32505      +19     
+ Misses        12338    12333       -5     
  Partials       1579     1579              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: nit: we can deploy a service with an ubuntu based image and then exec into the container to verify.

@KollaAdithya
Copy link
Contributor Author

I tested this on PopOS installed on my virtual machine.

@mergify mergify bot merged commit 66d1943 into aws:mainline Dec 19, 2023
12 checks passed
@KollaAdithya KollaAdithya deleted the ubuntu/fix/ssm branch January 19, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants