-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for ubuntu based distro to install ssm plugin #5571
Conversation
🍕 Here are the new binary sizes!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5571 +/- ##
============================================
+ Coverage 70.00% 70.02% +0.01%
============================================
Files 302 302
Lines 46403 46417 +14
Branches 301 301
============================================
+ Hits 32486 32505 +19
+ Misses 12338 12333 -5
Partials 1579 1579 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can deploy a service with an ubuntu based image and then exec into the container to verify.
I tested this on PopOS installed on my virtual machine. |
related #2561
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.