fix: account for tls termination in exposed port validation #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainCarpensir
requested review from
efekarakus
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mainline #5549 +/- ##
============================================
- Coverage 70.04% 70.03% -0.01%
============================================
Files 302 302
Lines 46331 46355 +24
Branches 309 309
============================================
+ Hits 32453 32466 +13
- Misses 12300 12309 +9
- Partials 1578 1580 +2 ☔ View full report in Codecov by Sentry. |
|
🍕 Here are the new binary sizes!
|
iamhopaul123
approved these changes
Dec 11, 2023
Lou1415926
approved these changes
Dec 11, 2023
Comment on lines
2243
to
+2249
| targetProtocol = strings.ToUpper(aws.StringValue(nlbProtocol)) | ||
| } | ||
|
|
||
| // Handle TLS termination of container exposed port protocol | ||
| if targetProtocol == TLS { | ||
| targetProtocol = TCP | ||
| } |
There was a problem hiding this comment.
I really am not a fan of nested if-block, but I think it's more obvious this way that we set the target protocol to TCP if the listener protocol is TLS, not necessarily if the target protocol is "tls". Imagine if we expand target_port to accept a string of form 443/tls (for example to let people configure e2e encryption), then this code might become slightly confusing to refactor.
Suggested change
| targetProtocol = strings.ToUpper(aws.StringValue(nlbProtocol)) | |
| } | |
| // Handle TLS termination of container exposed port protocol | |
| if targetProtocol == TLS { | |
| targetProtocol = TCP | |
| } | |
| if strings.EqualFold(aws.StringValue(nlbProtocol), "tls") { | |
| targetProtocol = TCP | |
| } else { | |
| targetProtocol = strings.ToUpper(aws.StringValue(nlbProtocol)) | |
| } |
KollaAdithya
added
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5536
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.