Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quotes to fix the invalid template for svc package for static site #5498

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

KollaAdithya
Copy link
Contributor

Related: #5472 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya KollaAdithya requested a review from a team as a code owner November 21, 2023 04:25
@KollaAdithya KollaAdithya requested review from huanjani and removed request for a team November 21, 2023 04:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (382fe1a) 70.03% compared to head (fcc7167) 70.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##           mainline    #5498   +/-   ##
=========================================
  Coverage     70.03%   70.03%           
=========================================
  Files           302      302           
  Lines         46064    46064           
  Branches        309      309           
=========================================
  Hits          32261    32261           
  Misses        12237    12237           
  Partials       1566     1566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 21, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56268 55192 🥺 +1.95
macOS (arm) 57272 56144 🥺 +2.01
linux (amd) 49340 48440 🥺 +1.86
linux (arm) 48640 47748 🥺 +1.87
windows (amd) 46504 45672 🥺 +1.82

@mergify mergify bot merged commit 262eefa into aws:mainline Nov 22, 2023
@iamhopaul123 iamhopaul123 changed the title chore: add quotes to fix the invalid template for svc package for static site fix: add quotes to fix the invalid template for svc package for static site Dec 11, 2023
@KollaAdithya KollaAdithya deleted the ogbuild/len branch December 20, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants