Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: scope down default permissions #5423

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

huanjani
Copy link
Contributor

@huanjani huanjani commented Oct 27, 2023

This disallows the Task Role and Instance Role from assuming Copilot-tagged roles (like EnvManager Role), and scopes down permissions of the CFN Execution Role].

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@huanjani huanjani requested a review from a team as a code owner October 27, 2023 22:26
@huanjani huanjani requested review from iamhopaul123 and removed request for a team October 27, 2023 22:26
@huanjani huanjani marked this pull request as draft October 27, 2023 22:26
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 52208 51976 +0.45
macOS (arm) 53064 52812 +0.48
linux (amd) 45924 45716 +0.45
linux (arm) 45252 45060 +0.43
windows (amd) 43368 43168 +0.46

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe2f0b3) 69.89% compared to head (afe65f6) 70.07%.
Report is 5 commits behind head on mainline.

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5423      +/-   ##
============================================
+ Coverage     69.89%   70.07%   +0.17%     
============================================
  Files           299      300       +1     
  Lines         45465    45776     +311     
  Branches        295      295              
============================================
+ Hits          31780    32079     +299     
- Misses        12140    12144       +4     
- Partials       1545     1553       +8     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huanjani huanjani marked this pull request as ready for review October 30, 2023 19:07
@mergify mergify bot merged commit cce61ba into aws:mainline Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants