Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cicd): replace dash in env name for TestCommands build project #2439

Merged
merged 2 commits into from
Jun 10, 2021
Merged

fix(cicd): replace dash in env name for TestCommands build project #2439

merged 2 commits into from
Jun 10, 2021

Conversation

efekarakus
Copy link
Contributor

Fixes #2437

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@efekarakus efekarakus requested a review from a team as a code owner June 10, 2021 18:20
@efekarakus efekarakus requested a review from Lou1415926 June 10, 2021 18:20
huanjani
huanjani approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Lou1415926
Lou1415926 reviewed Jun 10, 2021
View reviewed changes
Copy link
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we used ReplaceDashesFunc instead of StripNonAlphaNumfunc for logicalIDSafe for this template?

bvtujo
bvtujo approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@bvtujo bvtujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great turnaround on this bugfix!

@mergify mergify bot merged commit 28a1737 into aws:mainline Jun 10, 2021
@efekarakus efekarakus deleted the issues/fix-2437 branch June 10, 2021 19:01
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
@efekarakus @thrau
fix(cicd): replace dash in env name for TestCommands build project (a…
2c71e2e 
…ws#2439)

Fixes aws#2437

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvtujo bvtujo bvtujo approved these changes

@huanjani huanjani huanjani approved these changes

@Lou1415926 Lou1415926 Lou1415926 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create pipeline test commands if environment name has dashes
4 participants
@efekarakus @bvtujo @huanjani @Lou1415926