fix: support amazon-ecr-credential-helper & check for bucket existence before emptying the bucket #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…helper aws#2323 Depending on the value of `credsStore` attribute (inside docker config file), the code either performs the `docker login` or skips it.
efekarakus
added
the
do-not-merge
efekarakus
changed the title
efekarakus
reviewed
May 21, 2021
efekarakus
removed
the
do-not-merge
Co-authored-by: Efe Karakus <[email protected]>
Co-authored-by: Penghao He <[email protected]>
Co-authored-by: Efe Karakus <[email protected]>
Based on the documentation available [here](https://github.com/awslabs/amazon-ecr-credential-helper), `ecr-login` can be enabled globally using `credsStore` or on individual registry level. The recent code update considers both of this scenarios before letting it perform `docker login`
iamhopaul123
approved these changes
May 25, 2021
Co-authored-by: Penghao He <[email protected]>
Co-authored-by: Penghao He <[email protected]>
Thanks I have accepted the suggestions, appreciate the support on this. |
hariohmprasath
changed the title
efekarakus
added
the
do-not-merge
efekarakus
approved these changes
Jun 2, 2021
efekarakus
removed
the
do-not-merge
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
…e before emptying the bucket (aws#2365) ### Summary aws#2323 - Depending on the value of `credsStore` attribute (inside docker config file), the code either performs the `docker login` or skips it. aws#2070 - Added code to check for the existence of the bucket using `s3.HeadBucket` API before proceed to empty the contents ### Issue number Fixes aws#2323 & aws#2070 ---- By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2323 - Depending on the value of
credsStoreattribute (inside docker config file), the code either performs thedocker loginor skips it.#2070 - Added code to check for the existence of the bucket using
s3.HeadBucketAPI before proceed to empty the contentsIssue number
Fixes #2323 & #2070
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.